Skip to content

cleanup: fix incorrect logging info when volume is already mounted #2077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2025
Merged

cleanup: fix incorrect logging info when volume is already mounted #2077

merged 1 commit into from
Jul 16, 2025

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Jul 15, 2025 •
edited
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
cleanup: fix incorrect logging info when volume is already mounted

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

I0715 13:56:59.303034    5226 utils.go:104] GRPC call: /csi.v1.Node/NodePublishVolume
I0715 13:56:59.303059    5226 utils.go:105] GRPC request: {"staging_target_path":"/var/lib/kubelet/plugins/kubernetes.io/csi/blob.csi.azure.com/2f2914cc953e7e7b220e3e0426a57d4a467e8318328dd52fc51b26265bea50f7/globalmount","target_path":"/var/lib/kubelet/pods/ab987be3-90c7-48f9-a861-7e522cfb07d6/volumes/kubernetes.io~csi/pvc-8507f388-e9c3-4635-a0e1-dbc980fd9294/mount","volume_capability":{"AccessType":{"Mount":{"mount_flags":["-o allow_other","--file-cache-timeout-in-seconds=120","--use-attr-cache=true","--cancel-list-on-mount-seconds=10","-o attr_timeout=120","-o entry_timeout=120","-o negative_timeout=120","--log-level=LOG_WARNING","--cache-size-mb=1000"]}},"access_mode":{"mode":5}},"volume_context":{"clientID":"34719cde-3ea8-489e-8850-c0a4fd820348","containername":"pvc-8507f388-e9c3-4635-a0e1-dbc980fd9294","csi.storage.k8s.io/ephemeral":"false","csi.storage.k8s.io/pod.name":"statefulset-blob-1","csi.storage.k8s.io/pod.namespace":"default","csi.storage.k8s.io/pod.uid":"ab987be3-90c7-48f9-a861-7e522cfb07d6","csi.storage.k8s.io/pv/name":"pvc-8507f388-e9c3-4635-a0e1-dbc980fd9294","csi.storage.k8s.io/pvc/name":"persistent-storage-statefulset-blob-1","csi.storage.k8s.io/pvc/namespace":"default","csi.storage.k8s.io/serviceAccount.name":"andyblob","csi.storage.k8s.io/serviceAccount.tokens":"***stripped***","mountWithWorkloadIdentityToken":"true","protocol":"fuse2","secretnamespace":"default","skuName":"Premium_LRS","storage.kubernetes.io/csiProvisionerIdentity":"1752309724597-4783-blob.csi.azure.com","storageAccount":"andyblobtest"},"volume_id":"MC_andy-aks133_andy-aks133_eastus2euap#andyblobtest#pvc-8507f388-e9c3-4635-a0e1-dbc980fd9294##default#"}
I0715 13:56:59.303329    5226 nodeserver.go:84] NodePublishVolume: volume(MC_andy-aks133_andy-aks133_eastus2euap#andyblobtest#pvc-8507f388-e9c3-4635-a0e1-dbc980fd9294##default#) mount on /var/lib/kubelet/pods/ab987be3-90c7-48f9-a861-7e522cfb07d6/volumes/kubernetes.io~csi/pvc-8507f388-e9c3-4635-a0e1-dbc980fd9294/mount with service account token, clientID: 34719cde-3ea8-489e-8850-c0a4fd820348
I0715 13:56:59.335468    5226 nodeserver.go:678] already mounted to target /var/lib/kubelet/pods/ab987be3-90c7-48f9-a861-7e522cfb07d6/volumes/kubernetes.io~csi/pvc-8507f388-e9c3-4635-a0e1-dbc980fd9294/mount
I0715 13:56:59.335514    5226 blob.go:559] volumeID(MC_andy-aks133_andy-aks133_eastus2euap#andyblobtest#pvc-8507f388-e9c3-4635-a0e1-dbc980fd9294##default#) authEnv: []
I0715 13:56:59.335530    5226 blob.go:584] clientID(34719cde-3ea8-489e-8850-c0a4fd820348) is specified, use workload identity for blobfuse auth
I0715 13:56:59.335755    5226 blob.go:600] workload identity auth: [AZURE_STORAGE_SPN_CLIENT_ID=34719cde-3ea8-489e-8850-c0a4fd820348 AZURE_STORAGE_SPN_TENANT_ID=72f988bf-86f1-41af-91ab-2d7cd011db47 AZURE_OAUTH_TOKEN_FILE=/var/lib/kubelet/plugins/blob.csi.azure.com/34719cde-3ea8-489e-8850-c0a4fd820348andyblobtest]
I0715 13:56:59.335806    5226 nodeserver.go:337] NodeStageVolume: volume MC_andy-aks133_andy-aks133_eastus2euap#andyblobtest#pvc-8507f388-e9c3-4635-a0e1-dbc980fd9294##default# is already mounted on /var/lib/kubelet/pods/ab987be3-90c7-48f9-a861-7e522cfb07d6/volumes/kubernetes.io~csi/pvc-8507f388-e9c3-4635-a0e1-dbc980fd9294/mount
I0715 13:56:59.335878    5226 azure_metrics.go:105] "Observed Request Latency" latency_seconds=0.032473733 request="blob_csi_driver_node_stage_volume" resource_group="mc_andy-aks133_andy-aks133_eastus2euap" subscription_id="" source="blob.csi.azure.com" volumeid="MC_andy-aks133_andy-aks133_eastus2euap#andyblobtest#pvc-8507f388-e9c3-4635-a0e1-dbc980fd9294##default#" result_code="failed_csi_driver_node_stage_volume"

Release note:

none

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 15, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from cvvz and feiskyer July 15, 2025 14:05
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 15, 2025
@andyzhangx andyzhangx force-pushed the fix-incorrect-logging branch from fbb5ddc to 2c34a24 Compare July 15, 2025 14:31
@andyzhangx andyzhangx merged commit d84a738 into kubernetes-sigs:master Jul 16, 2025
21 of 22 checks passed
@andyzhangx
Copy link
Member Author

/cherrypick release-1.26

@andyzhangx
Copy link
Member Author

/cherrypick release-1.25

@andyzhangx
Copy link
Member Author

/cherrypick release-1.24

@andyzhangx
Copy link
Member Author

/cherrypick release-1.23

@k8s-infra-cherrypick-robot
Copy link

@andyzhangx: new pull request created: #2079

In response to this:

/cherrypick release-1.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jul 16, 2025
Merged
@k8s-infra-cherrypick-robot
Copy link

@andyzhangx: new pull request created: #2080

In response to this:

/cherrypick release-1.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jul 16, 2025
Merged
@k8s-infra-cherrypick-robot
Copy link

@andyzhangx: #2077 failed to apply on top of branch "release-1.24":

Patch is empty.
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To record the empty patch as an empty commit, run "git am --allow-empty".
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"

In response to this:

/cherrypick release-1.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot
Copy link

@andyzhangx: #2077 failed to apply on top of branch "release-1.23":

Patch is empty.
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To record the empty patch as an empty commit, run "git am --allow-empty".
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"

In response to this:

/cherrypick release-1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvvz cvvz Awaiting requested review from cvvz

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andyzhangx @k8s-ci-robot @k8s-infra-cherrypick-robot